Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing playback, thumbnail and storyboard token parameters in mux-player-react #821

Closed
1 task done
mmvsk opened this issue Nov 14, 2023 · 0 comments
Closed
1 task done
Labels
bug Something isn't working Status: Unconfirmed A potential issue that we haven't yet confirmed as a bug

Comments

@mmvsk
Copy link

mmvsk commented Nov 14, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Which Mux Elements/Packages does this apply to? Select all that apply

mux-player-react

Which browsers are you using?

Chrome

Which operating systems are you using?

Other (add details below)

Description

MuxPlayerReact is missing the following component props:

  • playbackToken (passed as playback-token to mux-player)
  • thumbnailToken (passed as thumbnail-token to mux-player)
  • storyboardToken (passed as storyboard-token to mux-player)

Reduced test case

No response

Steps to reproduce

  1. Try to add playbackToken, thumbnailToken or storyboardToken
  2. Those props does not exist

Current Behavior

Not implemented.

Expected Behavior

Should be implemented.

Errors

No response

What version of the package are you using?

v2.2.0

@mmvsk mmvsk added bug Something isn't working Status: Unconfirmed A potential issue that we haven't yet confirmed as a bug labels Nov 14, 2023
mmvsk added a commit to mmvsk/mux-elements that referenced this issue Nov 14, 2023
Add missing `playbackToken`, `thumbnailToken` and `storyboardToken` to
MuxPlayer react component.
@mmvsk mmvsk closed this as completed Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Status: Unconfirmed A potential issue that we haven't yet confirmed as a bug
Projects
None yet
Development

No branches or pull requests

1 participant