Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Cannot read properties of undefined (reading 'removeEventListener') #849

Closed
1 task done
VaniaPopovic opened this issue Dec 10, 2023 · 2 comments
Closed
1 task done
Assignees
Labels
bug Something isn't working

Comments

@VaniaPopovic
Copy link

VaniaPopovic commented Dec 10, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Which Mux Elements/Packages does this apply to? Select all that apply

mux-player, mux-player-react

Which browsers are you using?

Chrome

Which operating systems are you using?

Windows

Description

Hello, I updated my next project to version 14.0.5-canary.4 to enable a feature that I wanted, and mux-player-react started complaining about

Screenshot-mux

I didn't have this problem before, and I have also tried multiple versions of mux-react-player starting from 2.0 to 2.3

Reduced test case

No response

Steps to reproduce

  1. Include mux-player-react in a next js project with version 14.0.5-canary.4.
  2. Add a video to a page.
  3. It fails

Current Behavior

Videos don't load at all

Expected Behavior

For the videos to play normally.

Errors

Uncaught TypeError: Cannot read properties of undefined (reading 'removeEventListener')
at eval (webpack-internal:///(app-pages-browser)/../../node_modules/.pnpm/media-chrome@1.7.0/node_modules/media-chrome/dist/media-controller.js:220:15)
at Array.forEach ()
at eval (webpack-internal:///(app-pages-browser)/../../node_modules/.pnpm/media-chrome@1.7.0/node_modules/media-chrome/dist/media-controller.js:219:50)
at Array.forEach ()
at HTMLElement.mediaUnsetCallback (webpack-internal:///(app-pages-browser)/../../node_modules/.pnpm/media-chrome@1.7.0/node_modules/media-chrome/dist/media-controller.js:210:76)
at HTMLSlotElement.eval (webpack-internal:///(app-pages-browser)/../../node_modules/.pnpm/media-chrome@1.7.0/node_modules/media-chrome/dist/media-container.js:300:16)

It keeps printing this in a loop.

What version of the package are you using?

2.0.0 - 2.3.0

@VaniaPopovic VaniaPopovic added bug Something isn't working Status: Unconfirmed A potential issue that we haven't yet confirmed as a bug labels Dec 10, 2023
@VaniaPopovic
Copy link
Author

Noticed that it also happens on the mux-website
image
@ https://docs.mux.com/guides/player-themes#media-chrome-themes

@luwes luwes removed the Status: Unconfirmed A potential issue that we haven't yet confirmed as a bug label Dec 11, 2023
@luwes luwes self-assigned this Dec 11, 2023
luwes added a commit to luwes/media-chrome that referenced this issue Dec 11, 2023
luwes added a commit to muxinc/media-chrome that referenced this issue Dec 11, 2023
@VaniaPopovic
Copy link
Author

VaniaPopovic commented Dec 12, 2023

LGTM! The error dissapeared now with media-chrome 2.0.1. Thanks :)

@luwes luwes closed this as completed Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants