Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

News #56

Open
3 tasks
mytja opened this issue Sep 5, 2020 · 7 comments
Open
3 tasks

News #56

mytja opened this issue Sep 5, 2020 · 7 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@mytja
Copy link
Collaborator

mytja commented Sep 5, 2020

Sadly there is no news API or library, which means that sadly, we won't implement that

  • Improve our library
  • Use it in this project
  • Filter some stuff out of query
@mytja mytja self-assigned this Sep 5, 2020
@mytja mytja added help wanted Extra attention is needed enhancement New feature or request labels Sep 5, 2020
@mytja mytja added this to the v1.4 milestone Sep 5, 2020
@alexmercerind
Copy link
Collaborator

This ?

@mytja
Copy link
Collaborator Author

mytja commented Sep 7, 2020

@alexmercerind Thank you!
I'm trying to stay away as most as posdible from API keys, since you'd have to change code and api key... It is kind of hard to setup for a begginer. However, I think, I'm going to use this API, since news are very important!
Thank you so much for your help

@mytja mytja removed the help wanted Extra attention is needed label Sep 7, 2020
@mytja
Copy link
Collaborator Author

mytja commented Sep 7, 2020

And also, i'm going to make a library for easy integration...

@alexmercerind
Copy link
Collaborator

alexmercerind commented Sep 7, 2020

Oh great! That library can be a good independent project too.
Apart form that, when I initially started working with APIs, I used to store API keys as strings in my code (which is very risky for security if you use any SCM).
I'll recommend to not save API keys in code but to save them as "Environment Variables" in your PC and access them using Python's os.getenv(<API-KEY-NAME>). You can set them in Windows like this.

I don't know if you already know this. But I wanted to share it as it caused me a lot of trouble when I just started the development.
Thankyou.

@mytja
Copy link
Collaborator Author

mytja commented Sep 7, 2020

@alexmercerind Hello and thank you, I didn't know that.
For now, i will integrate them in function, but I will do this in the future.
Library will probably be done this weekend.
Thank you

@mytja
Copy link
Collaborator Author

mytja commented Sep 8, 2020

@alexmercerind
Library is done! 🎉
https://github.com/mytja/NewsAPI-Python

@mytja
Copy link
Collaborator Author

mytja commented Sep 10, 2020

  • Improve our library
  • Use it in this project
  • Filter some stuff out of query

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants