Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to provide a locale to display the local name #745

Open
babeuloula opened this issue Jan 15, 2025 · 3 comments
Open

Allow to provide a locale to display the local name #745

babeuloula opened this issue Jan 15, 2025 · 3 comments
Labels

Comments

@babeuloula
Copy link

More information

Hello,

With your API we can recover Belgium's public holidays. But in this country there are 3 official languages (French, German and Dutch).

Currently the translated value is only Dutch. If we could pass as countryCode BE-FR, BE-NL instead of just BE, this would allow us to translate them correctly.

Thanks

@tinohager
Copy link
Member

I would have already prepared the structure for this

                new HolidaySpecification
                {
                    Date = new DateTime(year, 1, 1),
                    EnglishName = "New Year's Day",
                    LocalName = "Nieuwjaar",
                    HolidayTypes = HolidayTypes.Public,
                    AdditionalTranslations = new Dictionary<string, string>
                    {
                        { "FR", "translation1" },
                        { "NL", "translation2" },
                        { "DE", "translation3" }
                    }
                },

@babeuloula
Copy link
Author

This would look great in the API. Do you have an implementation date?

@tinohager
Copy link
Member

The first step would be to collect the translations for the country. Then I could add it for Belgium and work on the API in the second step

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants