-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply fixes for Segmentfactory and Pluginmount #54
Comments
I know we’ve got people at work tinkering with the mapping stuff again. I’ll see if we can get it rebased on top of master if/when this gets merged in <3 |
So, if I understood correctly, best four you would be to merge this PR here, so @theangryangel & others could rebase work in #37 on top of that, right? For me this is ok - just give me your launch ok and I merge this PR. |
Exactly! Publishing those changes would give me the opportunity to depend on them in another project, which was developed on top of #37. For now, I’m untangling some internal stuff but hopefully have a first release as well as another PR for pydifact soon. 😊 |
#55 is merged. Closing this issue. |
Hey,
first, thanks for this amazing library, it has helped us a lot. I have noticed, that the in #37 proposed changes introduced more than a mapping functionality. With 23f218d fixes for the
PluginMount
and theSegmentFactory
were introduced, which allow the inheritance based extension ofSegment
, while correctly evaluating the__omitted__
attribute.With the current release this code
fails with
Could we merge those changes prior to the mapping extension? I will provide the necessary commits, but the credits belong to @theangryangel.
The text was updated successfully, but these errors were encountered: