Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make failed due to k8s version set to 1.28 in test container #905

Open
DonaldChung-HK opened this issue Jan 24, 2025 · 1 comment
Open

Comments

@DonaldChung-HK
Copy link

Hi,

Just a minor issue, It seems that in the test/Dockerfile.rocky-9 the k8s version is set to 1.28 which is deprecated and so it causes the dnf failed to resolved and thus the test container failed to build. This can be fixed be setting ARG kubernetes_version=1.29

Thanks

@DonaldChung-HK DonaldChung-HK changed the title make failed due to k8s version in test container make failed due to k8s version set to 1.28 in test container Jan 24, 2025
@ctalledo
Copy link
Member

Thanks @DonaldChung-HK for the heads-up.

I don't have a Rocky Linux machine so can't test, but would really appreciate it if you could make the fix(es) in the Dockerfile and open a PR.

Apart from updating kubernetes_version, I also see we need to update k8s_version and probably crictl_version too, but since I can't test it I prefer not to do it.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants