Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the same account address for managing testnet deployments? #302

Open
jcortejoso opened this issue May 23, 2022 · 0 comments
Open

Use the same account address for managing testnet deployments? #302

jcortejoso opened this issue May 23, 2022 · 0 comments

Comments

@jcortejoso
Copy link
Contributor

Is your feature request related to a problem? Please describe.

I noticed that current deployments use different accounts derived from the same mnemonic. For example:

Account [
  '0x73943d14131268F23b721E668911bCDDEcA9da62',
  '0x1ba74CaB4D011Fda10C26dc2bEDD810328a7fD72',
  '0x837b6AEd4d5fF4EDD356850EAdfE2a834b0e32C6',
  '0x0A0C7E21Efe52287E2f56cE4971c3cEbF5822aF3',
  '0x63D05A97C71f6EC29F2D062e83781806A5EaCe2C',
  '0x10f50eFd8F1Cae76e2f2F9f3A404E40667e7c4c6',
  '0x8AB347642bbE46BF59c185f18cd01F4D3626F54f',
  '0xA97D42F92993ceC67C96Cb944B9A19D99b1d75c0',
  '0xEbACD0f8972883C56b56316e67763196DF7fa9E4',
  '0xF2A177B1DF84D706ff1b5295404e133eEB4D67a7',
  '0x57a4a90E947Ee5524185Af448145FACb83a9CE7C',
  '0x75C2b399B2982bcc2245BADeCDE041197EEE85c6',
  '0x07826A4F5c21861822Ea4874374C81974C09fE98',
  '0xBaE71bcea4622Ee331b3bb36A86c2041832c3fE0',
  '0x1fA2f9996a4497DbD16cc0A4F013CB8546a2695E',
  '0xF79778Fd82c0030D2e8D6573Ed22046aC8136e82',
  '0x84D4bdEd3089a5f738aa13C76B0332036f1cf7FF',
  '0x41452D663dcfdD1612F11fDd10502218Fc237A75',
  '0x7BA51f978852CEF14A5553044A9Afd33a0f590eB',
  '0xc658191DB0b96C7c1d12aFA3440E9583801379ba'
]
Using default accounts
wallet {
  deployer: '0xEbACD0f8972883C56b56316e67763196DF7fa9E4',
  upgrader: '0xEbACD0f8972883C56b56316e67763196DF7fa9E4',
  governor: '0x57a4a90E947Ee5524185Af448145FACb83a9CE7C',
  ownerWallet: '0xEbACD0f8972883C56b56316e67763196DF7fa9E4',
  upgraderWallet: '0xEbACD0f8972883C56b56316e67763196DF7fa9E4',
  governorWallet: '0x57a4a90E947Ee5524185Af448145FACb83a9CE7C',
  contractNetworks: {}
}

The roles are configured in wallets.js as:

    let wallets = [
        { name: 'owner', account: accounts[8] },
        { name: 'upgrader', account: accounts[8] },
        { name: 'governor', account: accounts[10] }
    ]

Although having multiple roles with different addresses could be better for security/isolation purposes, it makes harder the balance management for testnets, particularly when the deployment process has to be automatized.

Describe the solution you'd like

It could be interesting being able to configure manually the key id for each role, or use [0] for testnets instead:

    let wallets = [
        { name: 'owner', account: accounts[0] },
        { name: 'upgrader', account: accounts[0] },
        { name: 'governor', account: accounts[0] }
    ]

Additional context

Add any other context or screenshots about the feature request here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant