Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imported Google Contacts adds "\" before a "," within a phone number (Please support the "," character) #1855

Open
Oclair opened this issue Oct 16, 2020 · 6 comments · Fixed by kewisch/ical.js#517
Labels
1. to develop Accepted and waiting to be taken care of bug Something isn't working dependencies feature: import Importing (and exporting) medium Medium priority

Comments

@Oclair
Copy link

Oclair commented Oct 16, 2020

Hi there,

I have a voice over IP provider whom I call locally to make international calls.

So I have setup in my contacts a "," which causes a 2 second pause so my VOIP provider can recieve the number I actually wish to call. for example the VOIP number is +99 1 5551212 and the number I wish to call is +1 202 555 1212. Therefore the contact uses the following number
+9915551212,0012025551212
The imported contact instead now has
+9915551212\,0012025551212

this "\" character is often used in PHP and HTML as a breakout character in coding and certainly should not be present within the telephone number for each imported contact.

the comma is an appropriate character for a telephone number within an addressbook

I cannot know how each implementation of my contacts will interpret this added character "\" it is not the data which should have been imported and indicates that the developer who coded the import function written in PHP does not expect a comma present within a telephone number

Nextcloud 19.0.4 Contacts 3.4.0 OS installed and updated on FreeBSD manually via CLI using the standard Nextcloud.com stable Channel

Please ping me when "," support has been added to this plugin so I can again re-import my contacts!

Thank you for the awesome work and contributions to the community!
OC

GoogleContactExportSamplesWithCommaInTelephoneNumber.zip

@Oclair Oclair added 0. Needs triage bug Something isn't working labels Oct 16, 2020
@Oclair
Copy link
Author

Oclair commented Oct 16, 2020

This Behavior occurred when importing a .vcf file generated by Google under the Export contacts feature for Contacts using the vCard (for iOS Contacts) format. I have updated the issue to include a sample with the 3 different export formats generated from a single contact.

@Oclair
Copy link
Author

Oclair commented Oct 16, 2020

BEGIN:VCARD
VERSION:3.0
FN:Nextcloud GitHub
N:GitHub;Nextcloud;;;
item1.TEL:+43 5551 212\,0012025551212
item1.X-ABLabel:
item2.ORG:Contacts
item2.X-ABLabel:
CATEGORIES:myContacts
END:VCARD!

Screenshot: https://i.ibb.co/RBKWmZV/Screenshot-2020-10-16-185938.jpg
Screenshot-2020-10-16-185938

Attempting to export that contacts generates a breakout for the comma in the phone number in the exported file.

@stefan123t
Copy link

stefan123t commented Oct 29, 2020

Same problem may occur with other special chars like # and * used for providing Telco details like conference room and/or password. Thanks for considering these too.

I researched and found the following RFC 6868 on escaping rules between iCalendar and vCard which may apply.

RFC 6868 Parameter Value Encoding in iCalendar and vCard
https://tools.ietf.org/html/rfc6868

@joshtrichards
Copy link
Member

Partially blocked on a new upstream release of ical.js: kewisch/ical.js#646

@joshtrichards
Copy link
Member

New ical.js release is out: https://github.com/kewisch/ical.js/releases/tag/v2.0.0

@joshtrichards joshtrichards added the feature: import Importing (and exporting) label Jun 15, 2024
@joshtrichards
Copy link
Member

v26 ical.js has been merged: #3941

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of bug Something isn't working dependencies feature: import Importing (and exporting) medium Medium priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants