Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Entry-point for PacBio CCS in BAM format #40

Closed
GallVp opened this issue Jan 7, 2025 · 2 comments
Closed

Entry-point for PacBio CCS in BAM format #40

GallVp opened this issue Jan 7, 2025 · 2 comments
Assignees
@GallVp
Labels
enhancement Improvement for existing functionality

Comments

@GallVp
Copy link
Member

GallVp commented Jan 7, 2025

Description of feature

I suggest that a bam_type column be added to the input schema (schema_input.json) to allow sample-wise skipping of the Compute CCS step. Its permissible values should be subread and ccs. The default should be subread. Thus, if the column is missing from the sample sheet, subread should be automatically selected. This will make sure that the new schema is backwards compatible. Moreover, if the bam column is missing, the bam_type column should be ignored.
@GallVp GallVp added the enhancement Improvement for existing functionality label Jan 7, 2025
@GallVp GallVp self-assigned this Jan 7, 2025
@GallVp GallVp mentioned this issue Jan 8, 2025
Merged
11 tasks
@sguizard
Copy link
Collaborator

I close it as the PR #41 is ready.
Thanks again for the contribution.

@GallVp
Copy link
Member Author

GallVp commented Jan 14, 2025

Thank you @sguizard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GallVp GallVp

Labels
enhancement Improvement for existing functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sguizard @GallVp