Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIND_ASSEMBLIES returns error code when no results are found #133

Open
zachary-foster opened this issue Jan 14, 2025 · 0 comments
Open

FIND_ASSEMBLIES returns error code when no results are found #133

zachary-foster opened this issue Jan 14, 2025 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@zachary-foster
Copy link
Contributor

zachary-foster commented Jan 14, 2025

This is low priority, since it does not prevent the pipeline for functioning correctly.

If a taxon is supplied for which there is no data, the following output is produced by datasets summary genome taxon --as-json-lines pseudeurotiaceae > Pseudeurotiaceae.json:

Error: The taxonomy name 'pseudeurotiaceae' (taxid: '34379') is valid, but no genome data is currently available for this taxon.

Use datasets summary genome taxon <command> --help for detailed help about a command.

The exitcode returned is 1, which makes nextflow think the process failed and it retries. In this case, it actually worked, there is just no data, so ideally it would return an exit code of 0 and an empty JSON file. A check should be added to modules/local/find_assemblies.nf for the phrase "is valid, but no genome data is currently available for this taxon" and make an empty JSON file and return exit code 0.

@zachary-foster zachary-foster added bug Something isn't working good first issue Good for newcomers labels Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant