Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single qutation mark ' in a comment makes AWS release full test break #3273

Open
jannikseidelQBiC opened this issue Nov 7, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@jannikseidelQBiC
Copy link

Description of the bug

A single quotation mark in the word "don't" in a comment on a release PR causes the AWS full test triggered upon two approvals to fail with exit code 2 before being dispatched on AWS.

This is the failed test run, and this is the link to the evil comment of @jfy133 :) I am going to edit this comment and re-run the test, hoping that this will fix the issue on this PR.

Please find a way to prevent others from blocking releases by using "don't" and similar words in comments. Thanks in advance! :)
@mashehu @mirpedrol

Command used and terminal output

No response

System information

No response

@jannikseidelQBiC jannikseidelQBiC added the bug Something isn't working label Nov 7, 2024
@jfy133
Copy link
Member

jfy133 commented Nov 7, 2024

I broke what with what?!?

@mashehu
Copy link
Contributor

mashehu commented Nov 7, 2024

You used an apostrophe in a comment, which breaks our string parsing...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants