Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility Mode Does Not Cache Result #20

Open
alexstandiford opened this issue May 27, 2022 · 1 comment · May be fixed by #21
Open

Compatibility Mode Does Not Cache Result #20

alexstandiford opened this issue May 27, 2022 · 1 comment · May be fixed by #21

Comments

@alexstandiford
Copy link
Contributor

Compatibility mode re-runs all checks to see if a site is in compatibility mode every time it is called. I would consider this a global setting where once determined it doesn't need to run again.

This should probably be changed to store the resulting value of the filter as a protected value in Nicholas, which is then used directly in subsequent calls to the method. This should keep the site from running a potentially expensive filter call every time this method is called.

@josh-tt
Copy link

josh-tt commented Aug 24, 2022

Ran into this when implementing IndexedDB and ended up caching it as nicholas-compatibilityModeUrls, and it gets cleaned up with the cache routines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants