OPTIONS response has invalid blank header with no value

[ewired]

I discussed the issue on the Fly help forum regarding the OPTIONS request responding with no CORS headers in #216. Fly's HTTP proxy is returning 502 because the OPTIONS response from Webdis has a blank : header with no name or value.

See two lines above last line:

< HTTP/1.1 200 OK
< Server: Webdis
< Allow: GET,POST,PUT,OPTIONS
< Access-Control-Allow-Methods: GET,POST,PUT,OPTIONS
< Access-Control-Allow-Origin: *
< Access-Control-Allow-Headers: X-Requested-With, Content-Type, Authorization
< Connection: Keep-Alive
< Content-Type: text/html
< Content-Length: 0
< :
<
* Connection #0 to host XYZZY.fly.dev left intact

https://community.fly.io/t/http-handler-502-errors-on-options-request/4160/5?u=ewired

[nicolasff]

Thanks for reporting this, I didn't see it yesterday when I ran it with an older version of Webdis but I can reproduce it on the latest. This is likely a regression from #205. /cc @jessie-murray

[nicolasff]

@jessie-murray I've tracked it down with git-bisect to your change in dc9d1b6.

This is due to the header replacement code in http_response_set_header, which overwrites the value here:

webdis/src/http.c

Lines 100 to 108 in dc9d1b6

	for(i = 0; i < r->header_count; ++i) {
	if(strncmp(r->headers[i].key, k, key_sz) == 0) {
	pos = i;
	/* free old value before replacing it. */
	if(r->headers[i].copy == HEADER_COPY_KEY) free(r->headers[i].key);
	if(r->headers[i].copy == HEADER_COPY_VALUE) free(r->headers[i].val);
	break;
	}
	}

but later still increments the header count:

webdis/src/http.c

Line 117 in dc9d1b6

r->header_count++;

It needs to avoid this increment if no new value was added. For the case of OPTIONS, somehow the Content-Length header is set twice, both times to 0. The second one causes this increment for which there's no key-value pair to write out.