Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rounding error in Log Glucose entry (and possibly elsewhere) #396

Closed
bjornoleh opened this issue Aug 24, 2024 · 1 comment
Closed

Rounding error in Log Glucose entry (and possibly elsewhere) #396

bjornoleh opened this issue Aug 24, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@bjornoleh
Copy link
Contributor

bjornoleh commented Aug 24, 2024

Describe the bug

When entering BG values in the Log Glucose screen, there is rounding applied at the time of entering values. This gives the wrong result sometimes. Confirmed for when entering the value of 9,2 mmol/L, which is immediately registered as 9,1 mmol/L.

To Reproduce

Steps to reproduce the behavior:

  1. Set BG units to mmol/L
  2. *Go to History / Glucose tab
  3. *Click on Log Glucose +
  4. *Enter 9,2
  5. *See the New Glucose value being entered as 9,1

Expected behavior

Duh :-)

Trio Version:

  • Version Number: [e.g. 0.2.0]
  • Repo: nightscout/trio
  • Git Reference: 6433d94

Technical Details

*Built to phone, but should be easily reproducible in any setup

I'd expect there to be more instances of this rounding error, but did not look for them yet.

@bjornoleh bjornoleh added bug Something isn't working needs-triage labels Aug 24, 2024
@Sjoerd-Bo3 Sjoerd-Bo3 added this to Trio Aug 24, 2024
@dnzxy
Copy link
Contributor

dnzxy commented Aug 26, 2024

Fixed with #398 .

@dnzxy dnzxy closed this as completed Aug 26, 2024
@github-project-automation github-project-automation bot moved this to Done in Trio Aug 26, 2024
Muppet1313 pushed a commit to Muppet1313/Trio that referenced this issue Dec 31, 2024
adding in liveactivity identifier

forcing xcode 15.0.1 for creating certs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

3 participants