-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
highlight inside generalized string literals #1
Comments
Yes correct, it begins the match when it sees
It would work equally nice and be more general. :) Just start at
I may be reading to much into this but what do you mean externally? Just that Nimib exports it? Or even more general so people doesn't neccecarily have to use Nimib to get access to
For ease of use, couldn't we just make
That is certainly true! |
Ok, think I've figured out what you meant now a day later. 🙃 |
ah yes 😊 |
I've been sitting all evening now trying to get |
for a first version to try out it is ok. It would need to be fix though at some point. unfortunately I have very limited knowledge of this to help (you might want to try and ask saem in the chat). |
Yes that makes sense. Found this issue though which seems to perhaps be relevant in this case: microsoft/vscode-textmate#139 It could be that the injected markdown grammar eats up the ending |
@pietroppeter Where do you think such |
Mmh, both options are fine. If you want to put them in a |
I'm a bit torn actually. Having it in |
Sounds fine. I guess we could start with |
Ok great! 👍 I'll spin up a PR for it immediately |
If I am seeing this correctly you are highlighting markdown now when you see string preceded by
nbText
, correct?What about providing a mechanism to highlight when provided with a
md
string literal that is just a marker.For example:
of course the template
md
should be provided externally (and if you want to use formatted string you would have to do stuff like&(md"hi **{name}**")
or defined afmd
template that ismd
+fmt
). The same mechanism could apply to html to highlight it (not necessarily relevant for nimib, but it could be useful in general).The text was updated successfully, but these errors were encountered: