Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

64 bit requirement play store #91

Open
Gonsaave opened this issue Aug 31, 2020 · 9 comments
Open

64 bit requirement play store #91

Gonsaave opened this issue Aug 31, 2020 · 9 comments

Comments

@Gonsaave
Copy link

Hi niqdev, hope you're doing well in these times.

I'm trying to publish an app using your library, but I can't due to the new 64 bit requeriment. I noticed there was another issue related to this, it was solved with a PR but it doesn't work for me.

I'm using version 1.7.0 of the library, maybe i'm missing something else?

Gradle:

implementation 'com.github.niqdev:mjpeg-view:1.7.0'

Any help is appreciated, thanks and stay safe.

@niqdev
Copy link
Owner

niqdev commented Aug 31, 2020

Hi @Gonsaave,
thanks, I hope you are doing well too!

Honestly I'm not actively developing with android in these days, although I have 2 apps on the store that use this lib, so it's in my interest to maintain at least compatibility and the project alive.

I don't know much about the new 64 bit requirements, but if you are able to figure it out and open a pr, I would be more than happy to merge any pr and release a new version of the lib. How does that sounds? I can help to point out to specific part of the code if you need it, also keep in mind that the NDK is not required to build the project and not used anymore.

Please let me know if you need any details to narrow down the issue

@Gonsaave
Copy link
Author

First off, thanks for the quick response!

I recently got back to Android development and saw all the changes in google politics, android 10 and other things, quite a lot has changed honestly. Although i'm no android expert, but i'll glady help if I can, so i'll check this and see if i can find anything (maybe it's something just related to my app even).

Again, any help is appreciated, i'll let you know if i need help, thanks!

@Gonsaave
Copy link
Author

Gonsaave commented Sep 7, 2020

Sorry for taking so long, was busy during the week. So i was able to give it a look during the weekend and after some research and testing, apparently the thing needed was to recompile the NDK with x86_64 added.

Correct me if i'm wrong @niqdev, i just modified the file Application.mk for mjpeg-view, recompiled and checked the APK with APK Analyzer (Android Studio) and everything seems alright now. Am i right or is there something else i'm missing?

@niqdev
Copy link
Owner

niqdev commented Sep 7, 2020

That's great news!
I would expect that you have done something similar to #81, isn't it? If that's the case and it works, would you mind opening a pr for that? I can publish a new version of the lib so that you can give me a feedback, wdyt?

@Gonsaave
Copy link
Author

Gonsaave commented Sep 8, 2020

Yes it's very similar to #81 (added x86_64 so the NDK compiles for 32 and 64 bits now). I'll open a new PR and i'll give you feedback on how it goes!

@jpage4500
Copy link

Hi @Gonsaave - any updates on this? i was looking for a good mjpg view to use for my app and this one seems very robust - but I didn't want to add it and then realize I can't use it in Google Play

@casic
Copy link

casic commented Jan 5, 2021

Hi @Gonsaave - is there already any solution ???
Best regards ?

@casic
Copy link

casic commented Jan 6, 2021

For all with this problem
Just use Mac or Linux . Open Application.mk , add x86_64 . Run ./compileJni.sh
New folder will appear in JniLbs /x86_64.
I hope this help someone

@Gonsaave
Copy link
Author

Hi everyone, i'm really sorry for leaving this issue pending all this time. Last year got really rough in my workplace and I couldn't come back to this. If anyone is still interested, I double checked my fix and it should work.

I can make a PR for this.

Again, i'm really sorry to everyone. Best regards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants