-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build fails with deprecated is_literal_type in hana dependency #168
Comments
Looks like this was fixed upstream with boostorg/hana@9cd5744 |
Quick question: which compiler are you using? I have never seen this error pop up before on any of the ones I test on from time to time. |
A repeat of what I put on the hana-adapter PR to make sure this information also appears here. I forgot to mention this: deprecation warnings get turned into errors due to the -Werror flag while compiling. You can actually switch that off in the NJOY21 CMakeLists.txt file. Removing the -Werror will revert to warnings again, and allow for compilation to continue. Either way, I'm testing ENDFtk right now with gcc 11.2 and I do see that deprecation warning so I will have to address it there. |
@whaeck Also getting this error. Trace:
|
As mentioned above, you can switch off the -Werror flag in the NJOY21 CMakeLists.txt file. This error is actually not an "error", just us being too thorough. We have looked into replacing the hana adapter with a direct dependency on the boost repository for this library but we have not pushed this change through over the entirety of the NJOY repositories. Updating the hana version removes the deprecation warning we are seeing here. However, on newer Mac systems the new hana version causes other warning that we also need to get rid off as well. Another solution would be to use NJOY2016 instead (NJOY21 uses NJOY2916 under the hood anyway, and that one actually compiles properly). |
@whaeck Should I need to do anything else beyond commenting this line:
because that alone results in the same build error |
Following build instructions on Ubuntu 22.04 LTS gives:
This was deprecated in C++17 (ref)
This comes from the hana dependency
The text was updated successfully, but these errors were encountered: