Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rounding errors are not catched properly #3

Open
jlaurens opened this issue Feb 23, 2020 · 0 comments
Open

rounding errors are not catched properly #3

jlaurens opened this issue Feb 23, 2020 · 0 comments

Comments

@jlaurens
Copy link

jlaurens commented Feb 23, 2020

Hi

almostEqual tests for absolute tolerance such that small values are always considered equal whereas big values are not.

With actual function

function almostEqual (left, right, tol) {
  return Math.abs(left - right) <= tol
}

the tests will pass when left === tol and right === 0 which may be weird, but is will not pass for big numbers.

Instead,

function almostEqual (left, right, tol) {
  return Math.abs(left - right) <= tol * (Math.abs(left)+Math.abs(right)+1) // the +1 for small
}

will pass only on rounding errors, whatever the magnitude of arguments is, either known in advance or not.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant