Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code blocks in-between lists causes issues and merging of lines #11

Closed
NessDan opened this issue Oct 12, 2022 · 5 comments
Closed

Code blocks in-between lists causes issues and merging of lines #11

NessDan opened this issue Oct 12, 2022 · 5 comments
Labels

Comments

@NessDan
Copy link

NessDan commented Oct 12, 2022

When writing the markdown shown here, the resulting md2html output looks like this:

## Adding SMTP Email support

1. Add the following line to your `build.gradle` file:

    ```kotlin
    implementation("REDACTED")
    ```

   * Please make sure to replace the version with the latest non-snapshot version of core.

1. In your `application.yml` file add the following properties:

    ```yaml
    smtp:
      host: localhost
      port: 25 # Optional (default 25)
      username: myusername # Optional
      password: mypassword # Optional
    ```

image

image

@nocd5
Copy link
Owner

nocd5 commented Oct 14, 2022

I seems that you use v1.
Would you please try v2 ?

md2html v2.0.0

Markdown parser is replaced from russross/blackfriday to yuin/goldmark at v2.
Fortunately the problem is solved by changes above.

Please note that code highlighting and color scheme is changes too.

@NessDan
Copy link
Author

NessDan commented Oct 14, 2022

Very interesting, will try v2 today!

Just a note @nocd5: We were originally installing this via go install github.com/nocd5/md2html@latest which was installing md2html v1.2

@NessDan
Copy link
Author

NessDan commented Oct 14, 2022

v2 fixes things, thank you so much!

Should I make a separate issue about the whole @latest pulling the wrong version of md2html?

@nocd5
Copy link
Owner

nocd5 commented Oct 17, 2022

Thanks for the report!

I've checked the same problem.
Could you make the issue?

@NessDan
Copy link
Author

NessDan commented Oct 17, 2022

@nocd5 done! :) I've created #12 ! 🫡

Thank you for your help with this! 🙇

@NessDan NessDan closed this as completed Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants