In the properties parameter of the DefineClass(...) function, the last item is not registered.

[crskycode]

I created an object using the following code

void Device::Initialize(Napi::Env env, Napi::Object exports)
{
  std::vector<Napi::ClassPropertyDescriptor<Device>> properties =
  {
    InstanceMethod("connect", &Device::Connect),
    InstanceMethod("disconnect", &Device::Disconnect),
    InstanceMethod("beep", &Device::Beep),
    InstanceMethod("beep1", &Device::Beep1), // undefined
  };

  Napi::Function constructorFunction = DefineClass(env, "MyDevice", properties);

  Napi::FunctionReference *constructor = new Napi::FunctionReference();
  *constructor = Napi::Persistent(constructorFunction);
  env.SetInstanceData(constructor);

  exports.Set("MyDevice", constructorFunction);
}

I can't see beep1 in JavaScript environment. Is this correct?

[legendecas]

Would you mind sharing a minimum reproducible setup, and sharing your environment information like Node.js version and platforms? Thank you!

[crskycode]

Would you mind sharing a minimum reproducible setup, and sharing your environment information like Node.js version and platforms? Thank you!

Node v20.12.0 on Windows

All code here

#include <napi.h>

class Device : public Napi::ObjectWrap<Device>
{
public:
  static void Initialize(Napi::Env env, Napi::Object exports);

  Device(const Napi::CallbackInfo& info);
  ~Device();

private:
  Napi::Value Connect(const Napi::CallbackInfo& info);
  Napi::Value Disconnect(const Napi::CallbackInfo& info);
  Napi::Value Beep(const Napi::CallbackInfo& info);
  Napi::Value Beep1(const Napi::CallbackInfo& info);
};

void Device::Initialize(Napi::Env env, Napi::Object exports)
{
  std::vector<Napi::ClassPropertyDescriptor<Device>> properties =
  {
    InstanceMethod("connect", &Device::Connect),
    InstanceMethod("disconnect", &Device::Disconnect),
    InstanceMethod("beep", &Device::Beep),
    InstanceMethod("beep1", &Device::Beep1), // undefined
  };

  Napi::Function constructorFunction = DefineClass(env, "MyDevice", properties);

  Napi::FunctionReference *constructor = new Napi::FunctionReference();
  *constructor = Napi::Persistent(constructorFunction);
  env.SetInstanceData(constructor);

  exports.Set("MyDevice", constructorFunction);
}

Device::Device(const Napi::CallbackInfo &info)
    : Napi::ObjectWrap<Device>(info)
{
}

Device::~Device()
{
}

Napi::Value Device::Connect(const Napi::CallbackInfo &info)
{
  return info.Env().Undefined();
}

Napi::Value Device::Disconnect(const Napi::CallbackInfo &info)
{
  return info.Env().Undefined();
}

Napi::Value Device::Beep(const Napi::CallbackInfo &info)
{
  return info.Env().Undefined();
}

Napi::Value Device::Beep1(const Napi::CallbackInfo &info)
{
  return info.Env().Undefined();
}

Napi::Object Initialize(Napi::Env env, Napi::Object exports)
{
  // Add Device module exports
  Device::Initialize(env, exports);
  return exports;
}

NODE_API_MODULE(mydevice, Initialize)

[legendecas]

I can not reproduce the problem, with noe-addon-api version 8.3.0, with the following JS snippet:

const binding = require('./build/Release/binding.node');
const descriptors = Object.getOwnPropertyDescriptors(binding.MyDevice.prototype);
console.log(descriptors);

Outputs:

{
  connect: {
    value: [Function: connect],
    writable: false,
    enumerable: false,
    configurable: false
  },
  disconnect: {
    value: [Function: disconnect],
    writable: false,
    enumerable: false,
    configurable: false
  },
  beep: {
    value: [Function: beep],
    writable: false,
    enumerable: false,
    configurable: false
  },
  beep1: {
    value: [Function: beep1],
    writable: false,
    enumerable: false,
    configurable: false
  },
  constructor: {
    value: [Function: MyDevice],
    writable: true,
    enumerable: false,
    configurable: true
  }
}

Would you mind sharing a minimum re-producible? thank you

[crskycode]

Thank you for your reply and let me first apologize for my lack of rigor.The problem is actually related to xorstr, for which I have provided a complete minimal example that reproduces the problem.

testaddon.zip