gcc 14.2.0 breaks the build of Node-20.9.0

[ddwolf]

Version

Node.js v20.9.0

Platform

$ uname -a
Linux kp920 6.11.0-13-generic #14-Ubuntu SMP PREEMPT_DYNAMIC Sun Dec  1 00:22:04 UTC 2024 aarch64 aarch64 aarch64 GNU/Linux

Subsystem

No response

What steps will reproduce the bug?

1. Ensure gcc14.2 was installed
2. build node-20.9.0 using standard method:

./configure --prefix=/usr/local/node-v20.9.0
make -j 64

How often does it reproduce? Is there a required condition?

It fails everytime. Only need GCC 14.2.0

What is the expected behavior? Why is that the expected behavior?

The build process should not fail.

What do you see instead?

In file included from ../deps/v8/src/heap/cppgc/process-heap-statistics.h:9,
                 from ../deps/v8/src/heap/cppgc/process-heap-statistics.cc:5:
../deps/v8/src/heap/cppgc/stats-collector.h: In member function ‘void cppgc::internal::StatsCollector::ForAllAllocationObservers(Callback)’:
../deps/v8/src/heap/cppgc/stats-collector.h:401:48: error: cannot convert ‘std::vector<cppgc::internal::StatsCollector::AllocationObserver*>::iterator’ to ‘const char*’
  401 |         std::remove(allocation_observers_.begin(), allocation_observers_.end(),
      |                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~^~
      |                                                |
      |                                                std::vector<cppgc::internal::StatsCollector::AllocationObserver*>::iterator

Additional information

Solution

using method suggested from this question

• Either include <algorithm> in the header file deps/v8/src/heap/cppgc/stats-collector.h
• Or build using gcc13: PATH=/usr/local/Python-3.11.0/bin:/usr/local/gcc-13.2.0/bin:$PATH make -j 64

[richardlau]

• Either include <algorithm> in the header file deps/v8/src/heap/cppgc/stats-collector.h

For Node.js 20, this was fixed in 20.10.0 by 4b243b5.