diff --git a/.github/workflows/comment-labeled.yml b/.github/workflows/comment-labeled.yml index 7e3a19c6afd13c..8ec84d8192d6b8 100644 --- a/.github/workflows/comment-labeled.yml +++ b/.github/workflows/comment-labeled.yml @@ -2,7 +2,7 @@ name: Comment on issues and PRs when labeled on: issues: types: [labeled] - pull_request_target: + pull_request: types: [labeled] env: @@ -35,7 +35,7 @@ jobs: fast-track: permissions: pull-requests: write - if: github.repository == 'nodejs/node' && github.event_name == 'pull_request_target' && github.event.label.name == 'fast-track' + if: github.repository == 'nodejs/node' && github.event_name == 'pull_request' && github.event.label.name == 'fast-track' runs-on: ubuntu-latest steps: - name: Request Fast-Track @@ -46,7 +46,7 @@ jobs: notable-change: permissions: pull-requests: write - if: github.repository == 'nodejs/node' && github.event_name == 'pull_request_target' && github.event.label.name == 'notable-change' + if: github.repository == 'nodejs/node' && github.event_name == 'pull_request' && github.event.label.name == 'notable-change' runs-on: ubuntu-latest steps: - name: Add notable change description diff --git a/.github/workflows/label-pr.yml b/.github/workflows/label-pr.yml index 95fdd42a4c700a..4b2fecdd61919c 100644 --- a/.github/workflows/label-pr.yml +++ b/.github/workflows/label-pr.yml @@ -1,7 +1,7 @@ name: Label PRs on: - pull_request_target: + pull_request: types: [opened] permissions: diff --git a/.github/workflows/notify-on-review-wanted.yml b/.github/workflows/notify-on-review-wanted.yml index b4e3490f31f3d6..0c07ad8e2344a3 100644 --- a/.github/workflows/notify-on-review-wanted.yml +++ b/.github/workflows/notify-on-review-wanted.yml @@ -2,7 +2,7 @@ name: Notify on Review Wanted on: issues: types: [labeled] - pull_request_target: + pull_request: types: [labeled] permissions: diff --git a/doc/contributing/commit-queue.md b/doc/contributing/commit-queue.md index cece9ea84e94f8..d2622a95e3525b 100644 --- a/doc/contributing/commit-queue.md +++ b/doc/contributing/commit-queue.md @@ -71,7 +71,7 @@ reasons: the last one to finish will fail because the local branch will be out of sync with the remote after the first Action pushes. `issue_comment` event has the same limitation. -2. `pull_request_target` will only run if the Action exists on the base commit +2. `pull_request` will only run if the Action exists on the base commit of a pull request, and it will run the Action version present on that commit, meaning we wouldn't be able to use it for already opened PRs without rebasing them first.