Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

design fix #36

Open
desislavsd opened this issue Sep 15, 2016 · 0 comments
Open

design fix #36

desislavsd opened this issue Sep 15, 2016 · 0 comments

Comments

@desislavsd
Copy link

Hi, I really like the way your plugin works!

However, zooming in/out the screen will reveal the native scrollbars. They are also visible before the plugin is applied, which is not a problem on initial load of the page, but when i dynamically add new elements.

I think this small improvement will do the job. It will be better if the .gm-scroll-view is absolutely positioned and has no fixed width and height. Let the developer set the width and the height of the wrapper (for example 100%/100%) and the .gm-scroll-view should be stretched with left: 0; top: 0; right: -[nativeScrollbarWidth]; bottom: -[nativeScrollbarWidth];, where the given css should be appended to the body the first time the plugin is used, since it needs to calculate the nativeScrollbarWidth. This way you will not have to resize the view every time the wrapper is resized, or for the sequential dynamically added elements, since the css will take care of that. In fact you did this with the scrollbars.

If something is not clear you may find similar approach with nanoScroller.js. But I prefer your plugin and i hope you will find my suggestion useful!

Best

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant