-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatic selection of flow colors is inconsistent #55
Comments
The initial flow coloring can be customized in the 'Flows' > 'Default Flow Colors' section. It looks like the option for 'use colors from..' > 'outermost nodes (flowing in)' is checked. If you select 'each flow's Source' instead, it should produce the colors you're looking for. |
Oh, wow, I totally missed that! So first of all, sorry for the unwarranted noise! 😅 but second, I do have some questions:
And an observation/suggestion: I appreciate the styling choice to deemphasize unselected options, but that sort of conflicts with the usual practice of deemphasized (i.e. greyed-out) elements being disabled, i.e. unselectable. I suspect this may have played a role in me overlooking the flow colors options — I probably just didn't read those options assuming they were disabled because they didn't apply to the diagram I was working with. Perhaps consider emphasizing the selected ones instead? I mean, the use of blue already provides some emphasis, but if that feels insufficient, maybe make them bold too, or add a soft background color? |
Is it possible to have a gradient set for the flow as an option next to the target and source? I see above that there is an issue of whether the color is the source or the target, but a gradient would solve that issue entirely—because you'd have both, so it doesn't matter. I imagine this might be complicated on the back end, but I think it would be very beautiful and intuitive for users to have this feature. Here is an example I made in PS to illustrate my point. From an understanding POV, this view helps us understand that money from one source turns into money from another source. Meaning, at no point is it really the source OR the target—it's both and that changes depending on the perspective. |
Currently, the way that colors are picked for the flow paths between nodes seems to be inconsistent: in some cases, the color of the source node is picked, but in others, the color of the target node. Perhaps the algorithm is deterministic, but it's not intuitive so it feels random.
Here's an example diagram, based on the data for the 2022 Wikimedia Foundation Board elections:
Note how the flows exiting the "Farah R1" node all share the color of the source node, and those leaving the "Kunal R2" node do the same, except for the one targeting the "Nobody" node. In contrast, those exiting the "Tobechukwu R3" and "Mike R4" nodes all have color of the destination node.
Source code:
And here's the diagram after manual tweaking of the colors in the SVG file:
IMO, the solution should be to consistently pick either the source or the destination nodes for the color of the connecting flows. I personally find the source color to be more intuitive.
Another solution could be to use a gradient from the source node color to the target node color, as proposed in #33.
The text was updated successfully, but these errors were encountered: