Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constants securityGroup and networkACL dup to FilterKindName() #724

Open
ShiriMoran opened this issue Jul 24, 2024 · 0 comments
Open

Constants securityGroup and networkACL dup to FilterKindName() #724

ShiriMoran opened this issue Jul 24, 2024 · 0 comments

Comments

@ShiriMoran
Copy link
Contributor

ShiriMoran commented Jul 24, 2024

  1. Right. Now using FilterKindName() and no need for the constants here
  2. FilterKindName() can not use these constants since they are defined in ibmvpc/commonvpc
  3. Perhaps we should modify the code in ibmvpc/commonvpc to use FilterKindName() - but not in this PR @adisos do you want to open a followup issue to handle this?

Originally posted by @ShiriMoran in #722 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants