Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a test with NACL rules specifying ICMP type and code #860

Open
ShiriMoran opened this issue Sep 9, 2024 · 0 comments
Open

Add a test with NACL rules specifying ICMP type and code #860

ShiriMoran opened this issue Sep 9, 2024 · 0 comments
Assignees
@olasaadi99
Labels
tests
Milestone
v0.8

Comments

@ShiriMoran
Copy link
Contributor

ShiriMoran commented Sep 9, 2024 •
edited
Loading

NACL such rules exists only at IBM's input_acl_testing5.json that does not have any instances

Need to add examples of NACL rules with reference to ICMP type and code in both IBM and AWS

Originally posted by @ShiriMoran in #856 (comment)
@ShiriMoran ShiriMoran mentioned this issue Sep 9, 2024
Merged
@zivnevo zivnevo added the tests label Sep 9, 2024
@zivnevo zivnevo added this to the v0.8 milestone Sep 9, 2024
@zivnevo zivnevo changed the title missing NACL rules with ICMP type and code Add a test with NACL rules specifying ICMP type and code Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@olasaadi99 olasaadi99

Labels
tests
Projects
None yet
Milestone
v0.8
Development

No branches or pull requests
3 participants
@zivnevo @ShiriMoran @olasaadi99