Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doubtful documentation of NodeInfo.Attribute #223

Open
cthulhu-rider opened this issue Jun 7, 2022 · 0 comments
Open

Doubtful documentation of NodeInfo.Attribute #223

cthulhu-rider opened this issue Jun 7, 2022 · 0 comments
Labels
documentation Improvements or additions to documentation I3 Minimal impact question Further information is requested S4 Routine U4 Nothing urgent

Comments

@cthulhu-rider
Copy link
Contributor

cthulhu-rider commented Jun 7, 2022

From netmap.NodeInfo.Attribute docs:

  // A string representation of the chain of attributes in NeoFS Storage
  // Node configuration uses ":" and "/" symbols, e.g.:
  //
  //        `NEOFS_NODE_ATTRIBUTE_1=key1:val1/key2:val2`
  //
  // Therefore the string attribute representation in the Node configuration must
  // use "\:", "\/" and "\\" escaped symbols if any of them appears in an attribute's
  // key or value.

The structure of the node attribute message provides needed feature of attribute inheritance. Mentioned doc part describes some sort of string interpretation for the particular storage node configuration. Do we need it in the protocol description? This seems like an implementation-dependent statements.

@cthulhu-rider cthulhu-rider added documentation Improvements or additions to documentation question Further information is requested triage labels Jun 7, 2022
@roman-khimov roman-khimov added U4 Nothing urgent S4 Routine I3 Minimal impact labels Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation I3 Minimal impact question Further information is requested S4 Routine U4 Nothing urgent
Projects
None yet
Development

No branches or pull requests

3 participants