From 9451383efac75bdace03b1a82294c328dd1d73a6 Mon Sep 17 00:00:00 2001 From: James Ellis Date: Mon, 5 Feb 2018 12:00:33 +1100 Subject: [PATCH] Update/remove certain todo doco --- src/connector/Event.php | 3 +-- src/connector/Message.php | 1 - src/mailer/Mailer.php | 2 -- src/models/MailgunEvent.php | 1 - 4 files changed, 1 insertion(+), 6 deletions(-) diff --git a/src/connector/Event.php b/src/connector/Event.php index d3567a9..dd93012 100644 --- a/src/connector/Event.php +++ b/src/connector/Event.php @@ -12,8 +12,7 @@ class Event extends Base { * @param string $begin an RFC 2822 formatted UTC datetime OR empty string for no begin datetime * @param string $event_filter see https://documentation.mailgun.com/en/latest/api-events.html#event-types can also be a filter expression e.g "failed OR rejected" * @param boolean $resubmit whether to resubmit events if possible - * @todo when two installs share the same api_domain, events will be synchronised to both install. - * Possible workaround is to tag each message with a specific install 'tag' and add this as a filter on event polling here + * @todo when two installs share the same api_domain, events will be synchronised to both install. Possible workaround is to tag each message with a specific install 'tag' and add this as a filter on event polling here */ public function pollEvents($begin = NULL, $event_filter = "", $resubmit = false, $extra_params = array()) { diff --git a/src/connector/Message.php b/src/connector/Message.php index 6ab1c4d..64e4003 100644 --- a/src/connector/Message.php +++ b/src/connector/Message.php @@ -276,7 +276,6 @@ public function storeTestMessage(\MailgunEvent $event) { /** * Given an Event, store its contents if it is > 2 days old and if config allows - * @todo encryption of downloaded message ? * @param \MailgunEvent $event * @param string $contents * @param boolean $force diff --git a/src/mailer/Mailer.php b/src/mailer/Mailer.php index 58a89d8..94988c9 100644 --- a/src/mailer/Mailer.php +++ b/src/mailer/Mailer.php @@ -57,7 +57,6 @@ public function setSender($email, $name = "") { /** * Send a message using the Mailgun messages API. If there is a submission source, save the resulting message.id on successful response - * @TODO once a message is sent, clear tags and submission? Leave test mode as-is? * @param string $to * @param string $from * @param string $subject @@ -167,7 +166,6 @@ final protected function saveResponse($message) { } /** - * TODO parse out any X- prefixed headers and add them as h:X-My-Header * TODO support all o:options in Mailgun API */ protected function addCustomParameters(&$parameters, $headers) { diff --git a/src/models/MailgunEvent.php b/src/models/MailgunEvent.php index 5c4aabe..9bec806 100644 --- a/src/models/MailgunEvent.php +++ b/src/models/MailgunEvent.php @@ -481,7 +481,6 @@ public static function StoreEvent(MailgunEventModel $event, $mailgun_message_id /** * Provide action buttons to allow a resubmit. Only failures marked 'permanent' can be resubmitted - temporary failures are retried by MG - * TODO permission check for button and resubmit() access */ public function getCMSActions() { $actions = parent::getCMSActions();