Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lock name is misleading #4

Open
jotego opened this issue Feb 6, 2021 · 0 comments
Open

lock name is misleading #4

jotego opened this issue Feb 6, 2021 · 0 comments

Comments

@jotego
Copy link

jotego commented Feb 6, 2021

The suffix _lock for signals latched for a clock cycle, for instance here.

Lock suggests that the signal will lock something else, whereas what happens here is that the signal is being latched.

I suggest using a suffix such as _latch or _flop or _ff, to avoid confusion.

I can make a PR if you agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant