Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The cookie check should check that Django's cookie is set #354

Open
christianp opened this issue Dec 4, 2024 · 0 comments
Open

The cookie check should check that Django's cookie is set #354

christianp opened this issue Dec 4, 2024 · 0 comments

Comments

@christianp
Copy link
Member

A common problem is that I accidentally set SESSION_COOKIE_SECURE = False when I put debug mode on, and then I get weird errors because the launch goes ahead, thinking cookies can be set, but it only checked pylti1p3's cookie, not Django's.

We should check that the request also includes Django's session and CSRF cookies, and document that if they're not set you should check the *_COOKIE_SECURE settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant