Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multi Instance: Refactor: nvim-tree.view #2826

Closed
alex-courtis opened this issue Jul 13, 2024 · 2 comments · May be fixed by #2864
Closed

Multi Instance: Refactor: nvim-tree.view #2826

alex-courtis opened this issue Jul 13, 2024 · 2 comments · May be fixed by #2864
Assignees
@raaymax
Milestone
Multi Instance - ...

Comments

@alex-courtis
Copy link
Member

alex-courtis commented Jul 13, 2024 •
edited
Loading

nvim-tree.view is a stateful singleton. Make it an instantiable class owned by Explorer.

All usages must go through the TreeExplorer singleton.

This will be more difficult than other such refactors, as configuration and state are conflated and both mutated. See #2811
@alex-courtis alex-courtis changed the title Discrete Tree: Multi Instance nvim-tree.view Multi Instance nvim-tree.view Jul 13, 2024
@alex-courtis alex-courtis moved this to Backlog in Multiple Instances Jul 13, 2024
@alex-courtis alex-courtis changed the title Multi Instance nvim-tree.view Multi Instance: Refactor: nvim-tree.view Jul 13, 2024
@alex-courtis alex-courtis moved this from Backlog to Ready in Multiple Instances Jul 14, 2024
@alex-courtis alex-courtis added the PR please nvim-tree team does not have the bandwidth to implement; a PR will be gratefully appreciated label Jul 14, 2024
raaymax added a commit that referenced this issue Aug 4, 2024
@raaymax
refactor(#2826): multi instance nvim-tree.view
fa051cf
@raaymax raaymax mentioned this issue Aug 4, 2024
Draft
@raaymax raaymax self-assigned this Aug 4, 2024
@raaymax raaymax moved this from Ready to In progress in Multiple Instances Aug 4, 2024
@raaymax raaymax removed their assignment Sep 8, 2024
@raaymax
Copy link
Collaborator

raaymax commented Sep 8, 2024

I’m stepping away from this task for now as my workload has increased significantly with the upcoming big release. I'll revisit it once things settle down a bit on my end.

@alex-courtis
Copy link
Member Author

I’m stepping away from this task for now as my workload has increased significantly with the upcoming big release. I'll revisit it once things settle down a bit on my end.

No worries; there's no hurry to implement this any time soon. nvim-tree is grateful for the incredible amount of work you've done so far.

@github-project-automation github-project-automation bot moved this from In progress to Done in Multiple Instances Sep 9, 2024
@alex-courtis alex-courtis removed the PR please nvim-tree team does not have the bandwidth to implement; a PR will be gratefully appreciated label Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@raaymax raaymax

Labels
None yet
Projects
Multiple Instances
Status: In progress
Milestone
Multi Instance - 1 - Refactor
Development

Successfully merging a pull request may close this issue.

refactor(#2826): multi instance nvim-tree.view nvim-tree/nvim-tree.lua
2 participants
@raaymax @alex-courtis