Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render queued messages differently in contact histories #384

Closed
rowanseymour opened this issue Dec 8, 2023 · 3 comments · Fixed by #385
Closed

Render queued messages differently in contact histories #384

rowanseymour opened this issue Dec 8, 2023 · 3 comments · Fixed by #385
Assignees

Comments

@rowanseymour
Copy link
Member

They could have a spinner, or be greyed... they ain't sent.

@ericnewcomer
Copy link
Member

How do we feel about something like this?
image

One issue here is the order is going to be creation order. Might make sense to have queued messages move to when they actually sent. But that sounds messy.

But once your queued messages send, your timeline is not a great representation of reality as it stands.

@ericnewcomer
Copy link
Member

Also to answer a previous question about updating status in contact history, we only poll for events after a timestamp reflective of the most recent event. So, this means only the status of the most recent event could potentially be updated. I've reworked that so it updates now, but this won't matter when a message from way back when eventually sends. Of course, that only matters for the current page view. So maybe not that big of a deal. And as mentioned before, probably not in a meaningful order for the user to show it when it was queued over when it was sent. So perhaps some thinking to do there.

@rowanseymour
Copy link
Member Author

I like the faded styling and it's helpful that it explicitly says Queued

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants