Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

virtio-net: clarify coalescing parameters settings #194

Open
hengqiali opened this issue May 28, 2024 · 3 comments
Open

virtio-net: clarify coalescing parameters settings #194

hengqiali opened this issue May 28, 2024 · 3 comments

Comments

@hengqiali
Copy link

hengqiali commented May 28, 2024

The device can set any initial coalescing parameters (0 or non-zero)
for the receive/send queue before the setting command is executed,
not just 0, enhancing device performance even without DIM enabled.

So we need to clarify descriptions that don't fit the behavior.

Solution: https://lore.kernel.org/virtio-comment/87le3qmibk.fsf@redhat.com/T/#m03c7ae7c9f605db32078ce04283f5175c17518d2

@mstsirkin
Copy link
Contributor

the link point to review, pls fix it to point at the proposal itself, and we'll vote

@hengqiali
Copy link
Author

the link point to review, pls fix it to point at the proposal itself, and we'll vote

Fixed.

@mstsirkin
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants