Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary dark theme selection in the options #194

Open
alexlnkp opened this issue Jan 23, 2025 · 0 comments
Open

Unnecessary dark theme selection in the options #194

alexlnkp opened this issue Jan 23, 2025 · 0 comments

Comments

@alexlnkp
Copy link

First of all, thanks for making a fork of the youtube-dl-gui! It's a very nice tool.
The options at the moment confuse me, though. Since the app is using GTK, having a checkbox for setting a dark theme is simply unnecessary, since the dark theme is a preference a user can make using a tool like nwg-look.

Without checking any additional checkboxes, my system theme is working correctly:
Image
(Maybe with an exception for the icons, which are rendered as if my theme is set to light, for some reason?)

If I check the "dark theme" checkbox in the options, here's the result:
Image
Which is not at all my system theme, nor is it my system-light theme.

You could make a dropdown menu to select your system GTK theme in the options, and give users ability to select which variation of their system theme they want.
I.e. : a dropdown with 3 options, Default, Light and Dark. Default uses the preferred system theme (as set in GTK options, see [1]), Light forces a light theme and Dark forces a dark theme.

[1]:

1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant