Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] ChatQnA helm chart should support remote inference endpoint #735

Open
yongfengdu opened this issue Jan 21, 2025 · 2 comments
Open
Labels
feature New feature or request

Comments

@yongfengdu
Copy link
Collaborator

Priority

P2-High

OS type

Ubuntu

Hardware type

Xeon-GNR

Running nodes

Single Node

Description

This PR introduced new manifests file and README to support remote inference endpoint, but this is not supported by helm chart deployment yet.
opea-project/GenAIExamples#1149
We should support this feature as it's common for user to choose a cloud provided endpoint.

@yongfengdu yongfengdu added the feature New feature or request label Jan 21, 2025
@yongfengdu
Copy link
Collaborator Author

First thing is ChatQnA should add support for endpoints configuration - LLM_SERVER_HOST_IP, LLM_SERVER_PORT, RERANK_SERVER_HOST_IP, RERANK_SERVER_PORT, EMBEDDING_SERVER_HOST_IP, EMBEDDING_SERVER_PORT which are defined at https://github.com/opea-project/GenAIInfra/blob/main/helm-charts/chatqna/templates/deployment.yaml#L37
So far, they are either hard coded, or auto spell by different backend.

Another thing is to add envs for passing TOKEN. In the above commit, they are CLIENTID, CLIENT_SECRET and TOKEN_URL for Oauth.
I'm not familiar with this and haven't figure out how the above 3 envs will be passed to the specified llm endpoint from the code.

Also we should consider the following:
Security way to protect the SECRET.
Other authentication method?

@yongfengdu
Copy link
Collaborator Author

Depends on this one.
chatqna is not using llm-uservice, so these ENVs will not be passed down to llm_endpoint.
opea-project/GenAIExamples#1453

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant