Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't use find_package to locate opentelemetry_fluentd #477

Closed
zurex opened this issue Aug 28, 2024 · 1 comment
Closed

Can't use find_package to locate opentelemetry_fluentd #477

zurex opened this issue Aug 28, 2024 · 1 comment
Labels
exporter:fluentd Fluentd Exporter

Comments

@zurex
Copy link
Contributor

zurex commented Aug 28, 2024

Describe your environment Describe any aspect of your environment relevant to the problem, including your platform, build system, version numbers of installed dependencies, etc. If you're reporting a problem with a specific version of a library in this repo, please check whether the problem has been fixed on main branch.

environment: Linux based system.
platform: x86-64
build system: CMake-3.27 & LLVM-18

Steps to reproduce
Describe exactly how to reproduce the error. Include a code sample if applicable.

find_package(opentelemetry-fluentd CONFIG)
cmake_print_variables(OPENTELEMETRY_CPP_FLUENTD_LIBRARIES)

What is the expected behavior?
What did you expect to see?
opentelemetry-cpp-fluentd::trace;opentelemetry-cpp-fluentd::logs

What is the actual behavior?
What did you see instead?

Empty

Additional context
Add any other context about the problem here.

In the description part of exporters/fluentd/cmake/opentelemetry-cpp-fluentd-config.cmake.in, it should return :

  • opentelemetry-cpp-fluentd::trace
  • opentelemetry-cpp-fluentd::logs

But it try to test the tar exiting or not by if(TARGET opentelemetry-fluentd-cpp::${_TEST_TARGET}), in this package it does't provide such project named as opentelemetry-fluentd-cpp. It should be opentelemetry-fluentd.

@marcalff
Copy link
Member

Closing, fixed by #478

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exporter:fluentd Fluentd Exporter
Projects
None yet
Development

No branches or pull requests

2 participants