Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jmx-scraper] align custom configuration with instrumentation #1662

Open
SylvainJuge opened this issue Jan 21, 2025 · 1 comment
Open

[jmx-scraper] align custom configuration with instrumentation #1662

SylvainJuge opened this issue Jan 21, 2025 · 1 comment

Comments

@SylvainJuge
Copy link
Contributor

SylvainJuge commented Jan 21, 2025

This is a follow-up task of #1651

In instrumentation (JMX insights), the otel.jmx.config option provides the path to a list of custom YAML metrics definitions, we currently use otel.jmx.custom.scraping.config which does not allow to use a list.

Proposal

  • rename otel.jmx.custom.scraping.config configuration option to otel.jmx.config
  • add support for a list of configuration files
  • providing compatibility with otel.jmx.custom.scraping.config is not required as this option only exists for jmx-scraper and is not expected to be widely used, the equivalent in jmx-gatherer was only supporting groovy.
@SylvainJuge
Copy link
Contributor Author

I'm also volunteering to fix this so you can assign it to me, but I plan to work on it only when #1651 has been merged though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant