Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[instrumentation] Support setting image pull policy for agent images #3575

Open
atoulme opened this issue Dec 27, 2024 · 3 comments · May be fixed by #3675
Open

[instrumentation] Support setting image pull policy for agent images #3575

atoulme opened this issue Dec 27, 2024 · 3 comments · May be fixed by #3675
Assignees
Labels
enhancement New feature or request

Comments

@atoulme
Copy link
Contributor

atoulme commented Dec 27, 2024

Component(s)

auto-instrumentation

Is your feature request related to a problem? Please describe.

The current setup relies on the default behavior of kubernetes imagePullPolicy as it is not set explicitly.

Describe the solution you'd like

Add a field to the instrumentation CRDs and config flags to support setting image pull policies globally or per instrumentation.

Describe alternatives you've considered

No response

Additional context

No response

@atoulme atoulme added enhancement New feature or request needs triage labels Dec 27, 2024
@swiatekm
Copy link
Contributor

swiatekm commented Jan 2, 2025

👍 I'm in favor of adding this.

@yuriolisa
Copy link
Contributor

Would the idea be like the following?

kind: Instrumentation
metadata:
  name: my-instrumentation
spec:
  exporter:
    endpoint: http://otel-collector:4317
  propagators:
    - tracecontext
    - baggage
    - b3
  sampler:
    type: parentbased_traceidratio
    argument: "0.25"
  imagePullPolicy: Always
  python:
    imagePullPolicy: IfNotPresent
    env:
      # Required if endpoint is set to 4317.
      # Python autoinstrumentation uses http/proto by default
      # so data must be sent to 4318 instead of 4317.
      - name: OTEL_EXPORTER_OTLP_ENDPOINT
        value: http://otel-collector:4318

If so, would you have interest to send a PR or can I work on this one?

@yuriolisa yuriolisa pinned this issue Jan 24, 2025
@yuriolisa yuriolisa unpinned this issue Jan 24, 2025
@yuriolisa yuriolisa pinned this issue Jan 24, 2025
@atoulme
Copy link
Contributor Author

atoulme commented Jan 25, 2025

Yes, you can do it like this.

@yuriolisa yuriolisa self-assigned this Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants