Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Builder to ThingBeingBuiltBuilder #2560

Closed
cijothomas opened this issue Jan 24, 2025 · 1 comment · Fixed by #2562
Closed

Rename Builder to ThingBeingBuiltBuilder #2560

cijothomas opened this issue Jan 24, 2025 · 1 comment · Fixed by #2562
Labels
A-common Area:common issues that not related to specific pillar
Milestone

Comments

@cijothomas
Copy link
Member

Example: https://github.com/open-telemetry/opentelemetry-rust/blob/main/opentelemetry-sdk/src/logs/log_emitter.rs#L182 where just Builder is used. Except for provider, every other place uses the name "ThingbeingBuiltBuilder" pattern.

Opening to see if there are suggestions/feedback on this. Otherwise, we should rename Builder to LoggerProviderBuilder and do this consistently across.

@cijothomas cijothomas added the A-common Area:common issues that not related to specific pillar label Jan 24, 2025
@cijothomas cijothomas added this to the 0.28.0 milestone Jan 24, 2025
@lalitb
Copy link
Member

lalitb commented Jan 24, 2025

I prefer the name LoggerProviderBuilder; in general, names should be more descriptive and self-explanatory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-common Area:common issues that not related to specific pillar
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants