Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

obs-server emits unencoded characters #1051

Open
jengelh opened this issue Jan 13, 2025 · 0 comments
Open

obs-server emits unencoded characters #1051

jengelh opened this issue Jan 13, 2025 · 0 comments

Comments

@jengelh
Copy link
Contributor

jengelh commented Jan 13, 2025

As discovered in openSUSE/osc#1681 , obs-server generates XML with unescaped characters, e.g. ANSI/ECMA color codes:

$ osc api /comments/request/1179916 | hexdump -C
00000000  3c 63 6f 6d 6d 65 6e 74  73 20 72 65 71 75 65 73  |<comments reques|
00000010  74 3d 22 31 31 37 39 39  31 36 22 3e 0a 20 20 3c  |t="1179916">.  <|
00000020  63 6f 6d 6d 65 6e 74 20  77 68 6f 3d 22 64 69 6d  |comment who="dim|
00000030  73 74 61 72 22 20 77 68  65 6e 3d 22 32 30 32 34  |star" when="2024|
00000040  2d 30 36 2d 31 31 20 31  33 3a 32 30 3a 34 37 20  |-06-11 13:20:47 |
00000050  55 54 43 22 20 69 64 3d  22 31 39 34 37 33 33 34  |UTC" id="1947334|
00000060  22 3e 79 6f 75 20 42 52  20 70 6f 73 74 67 72 65  |">you BR postgre|
00000070  73 71 6c 2c 20 79 65 74  2c 20 74 68 65 20 73 75  |sql, yet, the su|
00000080  70 70 6f 72 74 20 66 6f  72 20 74 68 61 74 20 69  |pport for that i|
00000090  73 20 64 69 73 61 62 6c  65 64 3a 0d 0a 0d 0a 60  |s disabled:....`|
000000a0  60 60 5b 20 20 20 31 35  73 5d 20 7c 20 20 50 6f  |``[   15s] |  Po|
000000b0  73 74 67 72 65 53 51 4c  3a 20 20 20 20 20 20 20  |stgreSQL:       |
000000c0  20 20 20 20 20 20 20 20  20 20 20 20 20 20 20 20  |                |
000000d0  20 20 20 20 20 20 20 20  20 20 20 20 1b 5b 33 38  |            .[38|
000000e0  6d 44 49 53 41 42 4c 45  44 1b 5b 6d 0f 20 20 20  |mDISABLED.[m.   |
000000f0  20 20 20 7c 60 60 60 3c  2f 63 6f 6d 6d 65 6e 74  |   |```</comment|
00000100  3e 0a 3c 2f 63 6f 6d 6d  65 6e 74 73 3e 0a        |>.</comments>.|

judging from the python-xml etree error in the other ticket, obs-server should probably encode the \x1b character(s) to &#31; or something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant