-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Javadoc is missing completely. Intellij "Jump to source" does not work #72
Comments
Thanks for the report! I'll fix this in the new year :) |
So in IntelliJ, if I click on "Download documentation" in the tooltip when hovering over a symbol, then it does work. I get documentation when hovering over symbols and I can also jump to source. Are you seeing something different? Regarding the empty javadocs JAR, apparently that's a known behavior of Kotlin libraries, but people seem to generally consider it a non-problem because downloading the sources (e.g. via the "Download documentation" button I mentioned) results in having the javadocs. Perhaps it's still worth looking into, but I would first be interested to understand if what I described above works for you, because it works for me. |
This is a new, empty project just with one dependency, the 0.8.1 is available since today/yesterday. In this project I do |
We are not debugging IntelliJ: this road leads nowhere. There are 1mln ways to configure IntelliJ, easy to get lost. Let us see what can be done with pure command-line and maven: this is quite easy to reproduce. I did again:
Still can not see this JAR file with documentation under What is the full path to this file on your machine ? |
I want to note that openai-java/openai-java-core/src/main/kotlin/com/openai/models/ChatCompletionCreateParams.kt Lines 31 to 32 in 2b735f9
I think right now we have some documentation on the service method that
Can you try hovering over something like Regarding the empty javadocs JAR, as I mentioned above, it seems expected for Java libraries written in Kotlin to emit empty javadocs JARs:
So if you still don't see documentation, then the question is why your documentation is not appearing even if sources are downloaded, since the sources have the documentation too. |
Well, here move videos with attempts to view documentation/sources, this time - on .model() method: v2.webm.mp4v1.webm.mp4 |
Well,
this proves nothing. Unless you have invented a magical way to transfer sources and documentation to other computers, sources and documentation are transferred using FILES. As the author of this library, you know where these files are. |
We now have javadoc in the jar as well as javadoc.io docs There are still many things undocumented, but we'll be adding more documentation over time. Please be patient; this is an alpha release :) |
Steps:
build project with maven
Run this:
mvn dependency:sources dependency:resolve -Dclassifier=javadoc
Check local repository:
This means - Javadoc is always empty! (there is no Javadoc in these 261 byte big files)
There are sources in openai-java-core-0.8.0-sources.jar - but it can not be viewed in Intellij, see below
Pointing cursor over OpenAIClient, ChatCompletionCreateParams -> no Javadoc for these classes.
"Jump to source" for these classes: it opens decompiled .class file. Clicking "Download sources" in Intellij - does NOT help!
RESULT:
Without Javadoc and without sources - this library is quite difficult to use!
The text was updated successfully, but these errors were encountered: