From fa7bfe82dafb02759a9a6dc7c8e7efb95be1478b Mon Sep 17 00:00:00 2001
From: MueezKhan246 <93375917+MueezKhan246@users.noreply.github.com>
Date: Tue, 10 Sep 2024 17:25:03 +0500
Subject: [PATCH] Removing unencrypted credentials from model (#2220)

* refactor: removed unencrypted credentials from sap config model
---
 CHANGELOG.rst                                    |  4 ++++
 enterprise/__init__.py                           |  2 +-
 .../sap_success_factors/models.py                | 16 ----------------
 3 files changed, 5 insertions(+), 17 deletions(-)

diff --git a/CHANGELOG.rst b/CHANGELOG.rst
index 002c361f9..29f99164d 100644
--- a/CHANGELOG.rst
+++ b/CHANGELOG.rst
@@ -17,6 +17,10 @@ Unreleased
 ----------
 * nothing unreleased
 
+[4.25.7]
+----------
+* refactor: removed unencrypted credentials from sap config model
+
 [4.25.6]
 ----------
 * refactor: making unencrypted credentials nullable so after removing refs tests can run
diff --git a/enterprise/__init__.py b/enterprise/__init__.py
index 45e7ced47..a2e3e77a7 100644
--- a/enterprise/__init__.py
+++ b/enterprise/__init__.py
@@ -2,4 +2,4 @@
 Your project description goes here.
 """
 
-__version__ = "4.25.6"
+__version__ = "4.25.7"
diff --git a/integrated_channels/sap_success_factors/models.py b/integrated_channels/sap_success_factors/models.py
index 002ee57ce..43fb6f765 100644
--- a/integrated_channels/sap_success_factors/models.py
+++ b/integrated_channels/sap_success_factors/models.py
@@ -74,14 +74,6 @@ class SAPSuccessFactorsEnterpriseCustomerConfiguration(EnterpriseCustomerPluginC
         (USER_TYPE_USER, 'User'),
         (USER_TYPE_ADMIN, 'Admin'),
     )
-    key = models.CharField(
-        max_length=255,
-        blank=True,
-        default='',
-        verbose_name="Client ID",
-        help_text=_("OAuth client identifier."),
-        null=True
-    )
 
     decrypted_key = EncryptedCharField(
         max_length=255,
@@ -138,14 +130,6 @@ def encrypted_key(self, value):
         verbose_name="SAP User ID",
         help_text=_("Success factors user identifier.")
     )
-    secret = models.CharField(
-        max_length=255,
-        blank=True,
-        default='',
-        verbose_name="Client Secret",
-        help_text=_("OAuth client secret."),
-        null=True
-    )
 
     decrypted_secret = EncryptedCharField(
         max_length=255,