-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add observability for DEFAULT_AUTHENTICATION_CLASSES #32899
Comments
Originally I was hoping to use DRF's |
@feanil: I wanted to see how and if we should use Let me explain:
I confirmed that this view has JwtAuthentication before SessionAuthentication here. So, some code is authenticating the user before we even get there using SessionAuthentication. It's just confusing. UPDATE: Additionally, adding a UPDATE 2:
Conclusion: We probably should not use |
I created the PR #33003, which basically implements this ticket. |
This work has been completed. |
This is ticket is for adding observability for #32802.
DefaultSessionAuthentication
class inedx-platform
as a lightweight wrapper toSessionAuthentication
, and that overridesauthenticate()
, similar to how it's done in JwtAuthentication, but simply adds the following monitoring before returning the result from super.We then update the setting in
edx-platform
to:The docstring of
DefaultSessionAuthentication
should explain that this should not be used anywhere except inDEFAULT_AUTHENTICATION_CLASSES
.BasicAuthentication
from this default list, since we don't really want it as a default. We could implement aDefaultBasicAuthentication
class with a custom attribute like we have in BearerAuthentication.The text was updated successfully, but these errors were encountered: