Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: if no V2 Libraries exist, calls to get_libraries are slow. #34075

Closed
Tracked by #33640
connorhaugh opened this issue Jan 18, 2024 · 2 comments
Closed
Tracked by #33640

Bug: if no V2 Libraries exist, calls to get_libraries are slow. #34075

connorhaugh opened this issue Jan 18, 2024 · 2 comments
Labels
content libraries misc Libraries Overhaul tech work not captured in the stories

Comments

@connorhaugh
Copy link
Contributor

connorhaugh commented Jan 18, 2024

Expected Behavior:
If an environment has no V2 libraries in existence, the studio view handler for Library Content Blocks,
https://studio/xblock/block_id/studio_view times out.
Here's the trace:
Screenshot 2024-01-18 at 10 08 41 AM
As a quick fix, I added a V2 lib to my site.
I then got this performance boost
Screenshot 2024-01-18 at 3 06 57 PM

t (an order of magnitude better)

This means that we need to make it so these calls:

v2_query = library_api.get_libraries_for_user(user)
v2_libs_with_meta = library_api.get_metadata(v2_query)
v2_libs = [(lib.key, lib.title) for lib in v2_libs_with_meta]

don't get sad and look for libraries that don't exist

specifically, I think the problem is blockstore's get get_bundles() method is called with None as input, which makes it sad.

@robrap robrap removed this from Arch-BOM Jan 19, 2024
@kdmccormick kdmccormick added the content libraries misc Libraries Overhaul tech work not captured in the stories label May 15, 2024
@kdmccormick
Copy link
Member

Need to confirm whether this is still true for Learning Core

@ormsbee
Copy link
Contributor

ormsbee commented Oct 25, 2024

Tested this locally, and it doesn't look like it's an issue with current implementation for Sumac.

@ormsbee ormsbee closed this as not planned Won't fix, can't repro, duplicate, stale Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content libraries misc Libraries Overhaul tech work not captured in the stories
Projects
None yet
Development

No branches or pull requests

3 participants