Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continuously bump django-stubs and djangorestframework-stubs #35275

Open
huniafatima-arbi opened this issue Aug 9, 2024 · 1 comment
Open

Comments

@huniafatima-arbi
Copy link
Contributor

huniafatima-arbi commented Aug 9, 2024

Updated issue

( Updated Dec 2024 by @kdmccormick )

To maximize the stability and usefulness of our typechecking, we should always be constraining django-stubs to a version which is compatible with whatever our django and mypy version is. Generally, for django-stubs, that will be the latest patch release of the same major version as django or one major version greater.

Also djangorestframework-stubs may or may not need to be constrained.

There unfortunately isn't an easy way to bump those constraints automatically, so we'll leave this GitHub issue open indefinitely.

Original issue

( Created Aug 2024 by @huniafatima-arbi )

The version of django-stubs we can use depends on which Django release we're using 1.16.0 works with Django 3.2 through 4.1. Once django is updated we can remove this constraint

@bmtcril
Copy link
Contributor

bmtcril commented Oct 17, 2024

Just as a side comment to this, we will probably always need this to be pinned since the version compatibility of this package depends on specific versions of both Django and mypy. https://github.com/typeddjango/django-stubs?tab=readme-ov-file#version-compatibility

@kdmccormick kdmccormick changed the title Unpin django-stubs and djangorestframework-stubs in edx-platform Bump django-stubs and djangorestframework-stubs in edx-platform Dec 20, 2024
@kdmccormick kdmccormick changed the title Bump django-stubs and djangorestframework-stubs in edx-platform Continuously bump django-stubs and djangorestframework-stubs Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants