Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEPR]: Remove waffle flag ENABLE_GLOBAL_STAFF_OPTIMIZATION #35649

Closed
pdpinch opened this issue Oct 14, 2024 · 5 comments
Closed

[DEPR]: Remove waffle flag ENABLE_GLOBAL_STAFF_OPTIMIZATION #35649

pdpinch opened this issue Oct 14, 2024 · 5 comments
Labels
depr Proposal for deprecation & removal per OEP-21

Comments

@pdpinch
Copy link
Contributor

pdpinch commented Oct 14, 2024

Proposal Date

2024-10-15

Target Ticket Acceptance Date

2025-01-08

Earliest Open edX Named Release Without This Functionality

Teak - 2025-04

Rationale

This waffle flag enables an optimization in the legacy Studio course list view that more efficiently loaded a very long list of courses. Typically, this only made a difference on deployments where users were staff on a very large number of courses, for example edx.org.

The flag does not function in the new studio (aka course authoring) MFE. In that context, loading a large list of courses is optimized by default.

Removal

We don't plan to test this flag in the Sumac release, since it would require reverting to the legacy studio interface.

After Sumac, the code for the flag can be removed. A naive search for the flag turns up just 4 locations, including 2 tests.

Replacement

The functionality has already been replaced in the current APIs used with the Studio MFE.

Deprecation

No response

Migration

No response

Additional Info

No response

Task List

No response

Announcement

https://discuss.openedx.org/t/deprecation-removal-waffle-flag-enable-global-staff-optimization/14693

@jristau1984
Copy link
Contributor

Already discussed in T&L: https://twou.slack.com/archives/C04BHDFQMDK/p1729090844945349

@pdpinch
Copy link
Contributor Author

pdpinch commented Oct 17, 2024

I don't think I have access to twou.slack.com links. What was the outcome of the discussion?

@pdpinch
Copy link
Contributor Author

pdpinch commented Jan 13, 2025

This DEPR was announced in https://discuss.openedx.org/t/deprecation-removal-waffle-flag-enable-global-staff-optimization/14693. There were no comments during the feedback period.

@jristau1984
Copy link
Contributor

Apologies @pdpinch I missed your follow up question from before. That discussion came to the conclusion there would be no impact. I did not mean to include the twou slack link in the public ticket.

@pdpinch
Copy link
Contributor Author

pdpinch commented Jan 20, 2025

The deprecated code has been removed.

@pdpinch pdpinch closed this as completed Jan 20, 2025
@github-project-automation github-project-automation bot moved this from Proposed to Removed in DEPR: Deprecation & Removal Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
depr Proposal for deprecation & removal per OEP-21
Projects
Status: Removed
Development

No branches or pull requests

2 participants