Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEPR]: Studio course page templates and javascript #36108

Open
64 tasks
KristinAoki opened this issue Jan 14, 2025 · 1 comment
Open
64 tasks

[DEPR]: Studio course page templates and javascript #36108

KristinAoki opened this issue Jan 14, 2025 · 1 comment
Labels
depr Proposal for deprecation & removal per OEP-21

Comments

@KristinAoki
Copy link
Member

KristinAoki commented Jan 14, 2025

Proposal Date

2025-01-14

Target Ticket Acceptance Date

2025-01-28

Earliest Open edX Named Release Without This Functionality

Teak - 2025-04

Rationale

This technology should be removed because it is fully replaced by the authoring MFE. Keeping the html files and rendering code for the legacy pages increases code debt as it will obsolete.

Removal

General removal

  • cms/djangoapps/contentstore/toggles.py, delete lines 238-554
  • cms/djangoapps/contentstore/rest_api/v1/serializers/course_waffle_flags.py
  • cms/djangoapps/contentstore/rest_api/v1/views/course_waffle_flags.py
  • cms/djangoapps/contentstore/rest_api/v1/views/tests/test_course_waffle_flags.py
  • cms/djangoapps/contentstore/utils.py, delete lines 290-429 and 444-506

Page specific removal

*For each of the pages' html files, the imported js factory should also be deleted

Course home

Course outline

Unit page

  • cms/djangoapps.contentstore/views/component.py, update line 154 to
if is_unit_page:

Course updates

Course pages

Course assets and files

Course videos

Schedule and details

Grading

Course team

Group configurations

Advanced Settings

Certificates

Import

  • cms/djangoapps.contentstore/views/import_export.py, update line 100 to
if not library:

Export

  • cms/djangoapps.contentstore/views/import_export.py, update line 349 to
if not library:

Checklist

Accessibility

Replacement

All of the removed html code will be replaced by code in the frontend-app-authoring repo. Below is a page by page breakdown with their primary code folder

There are additional folders inside frontend-app-learning that are being used as replacements.

Deprecation

No response

Migration

No response

Additional Info

Additional clean up will be needed when v2 libraries are fully rolled out. Currently import.hmtl, export.html, and container.html are used for libraries.

Task List

Course home

  • Remove waffle flag
  • Replace waffle flag dependent redirect with redirect as default
  • Remove associated html file
  • Remove associated js factories

Course outline

  • Remove waffle flag
  • Replace waffle flag dependent redirect with redirect as default
  • Remove associated html file
  • Remove associated js factories

Unit/container page

  • Remove waffle flag
  • Replace waffle flag dependent redirect with redirect as default
  • Remove associated html file
  • Remove associated js factories

Course updates

  • Remove waffle flag
  • Replace waffle flag dependent redirect with redirect as default
  • Remove associated html file
  • Remove associated js factories

Course pages

  • Remove waffle flag
  • Replace waffle flag dependent redirect with redirect as default
  • Remove associated html file
  • Remove associated js factories

Course assets and files

  • Remove waffle flag
  • Replace waffle flag dependent redirect with redirect as default
  • Remove associated html file
  • Remove associated js factories

Course videos

  • Remove waffle flag
  • Replace waffle flag dependent redirect with redirect as default
  • Remove associated html file
  • Remove associated js factories

Schedule and details

  • Remove waffle flag
  • Replace waffle flag dependent redirect with redirect as default
  • Remove associated html file
  • Remove associated js factories

Grading

  • Remove waffle flag
  • Replace waffle flag dependent redirect with redirect as default
  • Remove associated html file
  • Remove associated js factories

Course team

  • Remove waffle flag
  • Replace waffle flag dependent redirect with redirect as default
  • Remove associated html file
  • Remove associated js factories

Group configurations

  • Remove waffle flag
  • Replace waffle flag dependent redirect with redirect as default
  • Remove associated html file
  • Remove associated js factories

Advanced Settings

  • Remove waffle flag
  • Replace waffle flag dependent redirect with redirect as default
  • Remove associated html file
  • Remove associated js factories

Certificates

  • Remove waffle flag
  • Replace waffle flag dependent redirect with redirect as default
  • Remove associated html file
  • Remove associated js factories

Import

  • Remove waffle flag
  • Replace waffle flag dependent redirect with redirect as default
  • Remove associated html file
  • Remove associated js factories

Export

  • Remove waffle flag
  • Replace waffle flag dependent redirect with redirect as default
  • Remove associated html file
  • Remove associated js factories

Checklist

  • Remove associated html file
  • Remove associated js factories

Accessibility

  • Remove associated html file
  • Remove associated js factories
@github-actions github-actions bot added the depr Proposal for deprecation & removal per OEP-21 label Jan 14, 2025
@kdmccormick
Copy link
Member

Fantastic! Thank you for making this and for enumerating all the parts of it.

The React Unit editor is still in the progress, so I propose that we take it out of the scope of this deprecation, and use this ticket to track it separately:

Tangentially, for anyone else reading this ticket: please be aware that we have separate deprecation tickets to track the removal of the legacy component editors:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
depr Proposal for deprecation & removal per OEP-21
Projects
Status: Proposed
Development

No branches or pull requests

2 participants