-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update workflow for library-sourced content (Authoring MFE - Unit Page) #1464
Comments
@jmakowski1123 FYI |
cc @GlugovGrGlib for visibility. These are small additions being made to the new unit page MFE. |
@bradenmacdonald Now that the course unit is an iframe that displays the legacy UI, is this issue relevant? |
@navinkarkera Yes, we should be intercepting the events from the iframe and displaying this modal from the Authoring MFE, not from the legacy page. See how they're doing it for the "Move XBlock" modal: #1422 |
@jmakowski1123 @lizc577 @sdaitzman @marcotuts This is ready for AC testing on the sandbox |
@sdaitzman This issue is about displaying the preview changes modal from the new course unit page. You can test it here. The sandbox is set to take you legacy course unit page by default, but we flip this temporarily if required. |
Thanks @navinkarkera! Tested a few rounds of updates and the ignore changes feature. Just out of curiosity, what determines whether the legacy/updated course unit page will be shown? |
@sdaitzman It's a setting that the administrator controls. There is currently no way for users to toggle the setting nor choose for themselves (though that's something I've been pushing for). |
This is working for me on the new unit MFE page. One behavior nit: After I click either accept or reject, the page auto-jumps to the bottom of the unit page. I think it should jump back to the location of the component that was being synced, wherever it is within the unit outline. |
@jmakowski1123 Yes, it is a limitation of how the whole unit iframe is reloaded on accepting or rejecting changes. We can look into a way to reload the specific block which should eliminate the need to scroll anywhere. Created #1579 to track it. |
<CompareChangesWidget>
:The text was updated successfully, but these errors were encountered: