Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backend - Credit card - Enable multiple users to register the same credit card #995

Open
NamFra opened this issue Dec 16, 2024 · 0 comments
Open

Backend - Credit card - Enable multiple users to register the same credit card #995

NamFra opened this issue Dec 16, 2024 · 0 comments
Assignees
@jonathanreveille

Comments

@NamFra
Copy link

NamFra commented Dec 16, 2024 •
edited
Loading

Bug Report

Problematic behavior
It's currently not possible to register the same credit card for multiple accounts or users.
This is problematic in the following use cases:

  • An organization wants to pay on behalf of multiple members
  • A user creates a new account and wants to pay with a previously used card

The issue is technical: there is a uniqueness constraint on a field in the credit card model (the token sent by Payzen), which currently prevents us from saving the same card multiple times in the database.

Expected behavior/code
Allow saving the same credit card multiple times in the database.

Environment

  • Joanie version: 2.11.0

Possible Solution
Remove the uniqueness constraint on the token field and replace it with a constraint at the user level. Before implementing this change, we need to assess the impact of this new behavior.
If multiple users want to use the same credit card, there will be as many credit card entries as users in the database.

In pre-production, the same Lyra test cards can be used by different users. Perhaps understanding why they are successfully saved in the database could help resolve this issue?

Additional context/Screenshots
@jonathanreveille jonathanreveille self-assigned this Jan 7, 2025
@jonathanreveille jonathanreveille mentioned this issue Jan 14, 2025
Open
6 tasks
jonathanreveille added a commit that referenced this issue Jan 14, 2025
@jonathanreveille
✨(backend) credit card can have multiple owners
729b9a7 
We want to able a group of organization members to pay
their orders with a common credit card. We discovered
that we cannot do this action because of the unicity of
the token value received from the payment provider when
tokenizing a credit card. That lead us to block a new entry of
the same credit card for another user. To enable this, we
have decided to track down the different users who will
use the same credit card, and by this, introduce a
ManyToMany relation field named owners to the CreditCard
model. We kept the unicity of token this way, because
we don't want duplicates of the same card in our
database.

Fix #995
jonathanreveille added a commit that referenced this issue Jan 15, 2025
@jonathanreveille
✨(backend) credit card can have multiple owners
07eee05 
We want to able a group of organization members to pay
their orders with a common credit card. We discovered
that we cannot do this action because of the unicity of
the token value received from the payment provider when
tokenizing a credit card. That lead us to block a new entry of
the same credit card for another user. To enable this, we
have decided to track down the different users who will
use the same credit card, and by this, introduce a
ManyToMany relation field named owners to the CreditCard
model. We kept the unicity of token this way, because
we don't want duplicates of the same card in our
database.

Fix #995
jonathanreveille added a commit that referenced this issue Jan 15, 2025
@jonathanreveille
✨(backend) credit card can have multiple owners
4f6f03f 
We want to able a group of organization members to pay
their orders with a common credit card. We discovered
that we cannot do this action because of the unicity of
the token value received from the payment provider when
tokenizing a credit card. That lead us to block a new entry of
the same credit card for another user. To enable this, we
have decided to track down the different users who will
use the same credit card, and by this, introduce a
ManyToMany relation field named owners to the CreditCard
model. We kept the unicity of token this way, because
we don't want duplicates of the same card in our
database.

Fix #995
jonathanreveille added a commit that referenced this issue Jan 17, 2025
@jonathanreveille
✨(backend) credit card can have multiple owners
3dd93a8 
We want to able a group of organization members to pay
their orders with a common credit card. We discovered
that we cannot do this action because of the unicity of
the token value received from the payment provider when
tokenizing a credit card. That lead us to block a new entry of
the same credit card for another user. To enable this, we
have decided to track down the different users who will
use the same credit card, and by this, introduce a
ManyToMany relation field named owners to the CreditCard
model. We kept the unicity of token this way, because
we don't want duplicates of the same card in our
database.

Fix #995
jonathanreveille added a commit that referenced this issue Jan 17, 2025
@jonathanreveille
✨(backend) credit card can have multiple owners
1e8a134 
We want to able a group of organization members to pay
their orders with a common credit card. We discovered
that we cannot do this action because of the unicity of
the token value received from the payment provider when
tokenizing a credit card. That lead us to block a new entry of
the same credit card for another user. To enable this, we
have decided to track down the different users who will
use the same credit card, and by this, introduce a
ManyToMany relation field named owners to the CreditCard
model. We kept the unicity of token this way, because
we don't want duplicates of the same card in our
database.

Fix #995
jonathanreveille added a commit that referenced this issue Jan 20, 2025
@jonathanreveille
✨(backend) credit card can have multiple owners
1caf079 
We want to able a group of organization members to pay
their orders with a common credit card. We discovered
that we cannot do this action because of the unicity of
the token value received from the payment provider when
tokenizing a credit card. That lead us to block a new entry of
the same credit card for another user. To enable this, we
have decided to track down the different users who will
use the same credit card, and by this, introduce a
ManyToMany relation field named owners to the CreditCard
model. We kept the unicity of token this way, because
we don't want duplicates of the same card in our
database.

Fix #995
jonathanreveille added a commit that referenced this issue Jan 20, 2025
@jonathanreveille
✨(backend) credit card can have multiple owners
77774f8 
We want to able a group of organization members to pay
their orders with a common credit card. We discovered
that we cannot do this action because of the unicity of
the token value received from the payment provider when
tokenizing a credit card. That lead us to block a new entry of
the same credit card for another user. To enable this, we
have decided to track down the different users who will
use the same credit card, and by this, introduce a
ManyToMany relation field named owners to the CreditCard
model. We kept the unicity of token this way, because
we don't want duplicates of the same card in our
database.

Fix #995
jonathanreveille added a commit that referenced this issue Jan 24, 2025
@jonathanreveille
✨(backend) credit card can have multiple owners
03064f6 
We want to able a group of organization members to pay
their orders with a common credit card. We discovered
that we cannot do this action because of the unicity of
the token value received from the payment provider when
tokenizing a credit card. That lead us to block a new entry of
the same credit card for another user. To enable this, we
have decided to track down the different users who will
use the same credit card, and by this, introduce a
ManyToMany relation field named owners to the CreditCard
model. We kept the unicity of token this way, because
we don't want duplicates of the same card in our
database.

Fix #995
jonathanreveille added a commit that referenced this issue Jan 24, 2025
@jonathanreveille
✨(backend) credit card can have multiple owners
6feda58 
We want to able a group of organization members to pay
their orders with a common credit card. We discovered
that we cannot do this action because of the unicity of
the token value received from the payment provider when
tokenizing a credit card. That lead us to block a new entry of
the same credit card for another user. To enable this, we
have decided to track down the different users who will
use the same credit card, and by this, introduce a
ManyToMany relation field named owners to the CreditCard
model. We kept the unicity of token this way, because
we don't want duplicates of the same card in our
database.

Fix #995
jonathanreveille added a commit that referenced this issue Jan 27, 2025
@jonathanreveille
✨(backend) credit card can have multiple owners
932e906 
We want to able a group of organization members to pay
their orders with a common credit card. We discovered
that we cannot do this action because of the unicity of
the token value received from the payment provider when
tokenizing a credit card. That lead us to block a new entry of
the same credit card for another user. To enable this, we
have decided to track down the different users who will
use the same credit card, and by this, introduce a
ManyToMany relation field named owners to the CreditCard
model. We kept the unicity of token this way, because
we don't want duplicates of the same card in our
database.

Fix #995
jonathanreveille added a commit that referenced this issue Jan 27, 2025
@jonathanreveille
✨(backend) credit card can have multiple owners
6552d2e 
We want to able a group of organization members to pay
their orders with a common credit card. We discovered
that we cannot do this action because of the unicity of
the token value received from the payment provider when
tokenizing a credit card. That lead us to block a new entry of
the same credit card for another user. To enable this, we
have decided to track down the different users who will
use the same credit card, and by this, introduce a
ManyToMany relation field named owners to the CreditCard
model. We kept the unicity of token this way, because
we don't want duplicates of the same card in our
database.

Fix #995
jonathanreveille added a commit that referenced this issue Jan 27, 2025
@jonathanreveille
✨(backend) credit card can have multiple owners
b365d6b 
We want to able a group of organization members to pay
their orders with a common credit card. We discovered
that we cannot do this action because of the unicity of
the token value received from the payment provider when
tokenizing a credit card. That lead us to block a new entry of
the same credit card for another user. To enable this, we
have decided to track down the different users who will
use the same credit card, and by this, introduce a
ManyToMany relation field named owners to the CreditCard
model. We kept the unicity of token this way, because
we don't want duplicates of the same card in our
database.

Fix #995
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonathanreveille jonathanreveille

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@NamFra @jonathanreveille