Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test branch protection for automated commits from GitHub Actions #553

Open
tomkralidis opened this issue Jun 19, 2024 · 2 comments
Open
Assignees
Labels
Cross-SWG Discussion documentation Improvements or additions to documentation

Comments

@tomkralidis
Copy link
Collaborator

There are problems with GitHub Actions for the bundle building example.

This may be rooted in branch protection rules causing this issue.

Test unsetting branch protection PR rules.

cc @chris-little @gbuehler @ghobona

@tomkralidis tomkralidis self-assigned this Jun 19, 2024
@tomkralidis
Copy link
Collaborator Author

As suspected, unsetting "Require a pull request before merging" resulted in success. OpenAPI bundle builds/commits/pushes fine now.

Having said this, we no longer have this setting, but I think we still do want only PRs to update the branch, with 2 approvals.

Options:

  1. Set "Require a pull request before merging" (bundle build fails, approval workflow intact. Only build / push OpenAPI at milestone stages
  2. Unset "Require a pull request before merging" (bundle build passes, approval workflow not intact. Bundle always up to date
  3. other options?

IMO I would propose option 2 (current setting as a result of unsetting) and we keep the PR/2 approval workflow as a SWG rule, even if it is not explicitly set in GitHub.

Thoughts @chris-little @solson-nws @ShaneMill1 @m-burgoyne ?

@solson-nws
Copy link
Collaborator

I agree with @tomkralidis on option 2

@chris-little chris-little added documentation Improvements or additions to documentation Cross-SWG Discussion labels Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cross-SWG Discussion documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants